Clean up + report in PDF.

[crypto_lab2.git] / labo2-fsharp / CryptoFile / API.fs

diff --git a/labo2-fsharp/CryptoFile/API.fs b/labo2-fsharp/CryptoFile/API.fs
index d4b9ad5..886b0d9 100644 (file)
--- a/labo2-fsharp/CryptoFile/API.fs
+++ b/labo2-fsharp/CryptoFile/API.fs
@@ -9,7 +9,7 @@ type internal Metadata (d: (string * string) list) =
     new (stream : Stream) =
         let reader = new BinaryReader (stream)
         let length = reader.ReadByte () |> int
-        new Metadata ([for i in 1..length -> reader.ReadString (), reader.ReadString ()])
+        Metadata ([for i in 1..length -> reader.ReadString (), reader.ReadString ()])
 
     // Write metadata to a stream.
     member this.WriteTo (stream : Stream) =
@@ -34,10 +34,10 @@ module API =
 
     let encryptFile (inputFilePath : string) (outputFilePath : string) (signaturePrivKey: Key) (cryptPubKey : Key)  =
         let keyAES, keyMAC, iv = Crypto.rand 16, Crypto.rand 32, Crypto.rand 16
-        let fileInfo = new FileInfo (inputFilePath)
+        let fileInfo = FileInfo (inputFilePath)
         use inputStream = fileInfo.OpenRead ()
         use outputStream = new FileStream (outputFilePath, FileMode.Create, FileAccess.Write)
-        let writer = new BinaryWriter (outputStream)
+        use writer = new BinaryWriter (outputStream)
 
         outputStream.Position <- 32L + 256L // Skips mac and signature. They will be written later.
 
@@ -46,11 +46,11 @@ module API =
         // Plaintext -> cryptoStream -> hmacStream -> cyphertext.
         let hmacStream, hmac = Crypto.HMACStream keyMAC outputStream
         use cryptoStream = Crypto.encryptAES keyAES iv hmacStream
-        let cryptoWriter = new BinaryWriter (cryptoStream)
+        use cryptoWriter = new BinaryWriter (cryptoStream)
 
         // Write the file metadata.
-        let metaData = new Metadata ([MetadataKeys.filename, fileInfo.Name
-                                      MetadataKeys.modificationTime, fileInfo.LastWriteTimeUtc.Ticks.ToString ()])
+        let metaData = Metadata ([MetadataKeys.filename, fileInfo.Name
+                                  MetadataKeys.modificationTime, fileInfo.LastWriteTimeUtc.Ticks.ToString ()])
         metaData.WriteTo cryptoStream
 
         // Write the content of the file.
@@ -93,12 +93,12 @@ module API =
         // Decrypt metadata.
         inputStream.Position <- 32L + 256L + 256L
         use cryptoStream = Crypto.decryptAES keyAES iv inputStream
-        let metadata = new Metadata (cryptoStream)
+        let metadata = Metadata (cryptoStream)
 
         // Create the file and write its content and metadata.
         let filePath = Path.Combine (targetDirPath, metadata.get MetadataKeys.filename)
-        let modificationTime = new DateTime (metadata.get MetadataKeys.modificationTime |> int64)
-        let fileInfo = new FileInfo (filePath)
+        let modificationTime = DateTime (metadata.get MetadataKeys.modificationTime |> int64)
+        let fileInfo = FileInfo (filePath)
         using (fileInfo.Create ()) <| fun outputStream -> cryptoStream.CopyTo outputStream
         fileInfo.LastWriteTimeUtc <- modificationTime
     
\ No newline at end of file